Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart #72

Merged
merged 24 commits into from
May 31, 2022
Merged

Helm chart #72

merged 24 commits into from
May 31, 2022

Conversation

maruina
Copy link
Collaborator

@maruina maruina commented May 30, 2022 •
edited
Loading

  • Add the Helm chart ported from kustomize build config/default
  • Build on top of kms-controller helm chart #35
  • Add an helm workflow to test the chart and make sure the docs are up to date
  • Add a Release action to publish the helm charts to Github Pages
  • Update the README with how to install instructions
  • Haven't enabled the Github Actions yet because I need to point it to an existing branch, so we need to cut a release first.

@maruina maruina marked this pull request as ready for review May 31, 2022 09:42
@maruina maruina requested a review from a team as a code owner May 31, 2022 09:42
Smirl
Smirl requested changes May 31, 2022
View reviewed changes
.github/workflows/helm.yml
if: steps.list-changed.outputs.changed == 'true'

- name: Build the testing kms-issuer docker image
run: docker build -t ${IMG} .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do a lot of building the docker image, creating kind clusters, etc. Might be nice if we could share some of this in a single workflow. Using caches between jobs?

.github/workflows/helm.yml
runs-on: ubuntu-latest
env:
IMG: skyscanner/kms-issuer:dev
CERT_MANAGER_VERSION: v1.8.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the concept of environments in github actions. We could perhaps put this shared value there?

.github/workflows/release.yml Show resolved Hide resolved
charts/kms-issuer/crds/kmsissuers.cert-manager.skyscanner.net.yaml Show resolved Hide resolved
charts/kms-issuer/templates/config.yaml Outdated Show resolved Hide resolved
charts/kms-issuer/templates/rbac.yaml Show resolved Hide resolved
charts/kms-issuer/templates/rbac.yaml Show resolved Hide resolved
charts/kms-issuer/templates/rbac.yaml Show resolved Hide resolved
charts/kms-issuer/templates/rbac.yaml Outdated Show resolved Hide resolved
charts/kms-issuer/templates/service.yaml Show resolved Hide resolved
@maruina maruina force-pushed the helm-chart branch 2 times, most recently from 125c69e to dba3860 Compare May 31, 2022 13:59
Smirl
Smirl approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@Smirl Smirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maruina maruina merged commit 00d54fc into main May 31, 2022
@maruina maruina deleted the helm-chart branch May 31, 2022 14:14
@maruina maruina mentioned this pull request May 31, 2022
Closed
@maruina maruina added the enhancement New feature or request label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smirl Smirl Smirl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maruina @Smirl