🐛 Fixed issues with comparisons and description

SkytAsul · Apr 6, 2023 · aa44729 · aa44729
1 parent 4efaf6e
commit aa44729
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/core/src/main/java/fr/skytasul/quests/api/comparison/ItemComparisonMap.java b/core/src/main/java/fr/skytasul/quests/api/comparison/ItemComparisonMap.java
@@ -110,8 +110,10 @@ public boolean isSimilar(ItemStack item1, ItemStack item2) {
 			Boolean result = null;
 
 			if (comparison.isMetaNeeded()) {
-				if (meta1 != meta2) continue;
-				if (!meta1) result = true;
+				if (meta1 != meta2)
+					result = false;
+				else if (!meta1)
+					result = true;
 			}
 
 			if (result == null) result = comparison.isSimilar(item1, item2);

diff --git a/core/src/main/java/fr/skytasul/quests/options/OptionDescription.java b/core/src/main/java/fr/skytasul/quests/options/OptionDescription.java
@@ -21,7 +21,9 @@ public class OptionDescription extends QuestOptionString implements QuestDescrip
 	@Override
 	public void setValue(String value) {
 		super.setValue(value);
-		cachedDescription = null;
+
+		if (cachedDescription != null) // not in constructor
+			cachedDescription.invalidateAll();
 	}
 
 	@Override