Skip to content

Commit

Permalink
Merge pull request #255 from SkywardAI/fix/devcontainer
Browse files Browse the repository at this point in the history
Fix devcontainer and bump version
  • Loading branch information
Aisuko authored Jul 14, 2024
2 parents 10bd87a + fb9d189 commit bf1e777
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 13 deletions.
13 changes: 6 additions & 7 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,8 @@
"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
"features": {
"ghcr.io/jungaretti/features/make:1": {},
"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
"moby": true,
"installDockerBuildx": true,
"version": "latest",
"dockerDashComposeVersion": "v2"
}
"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {},
"ghcr.io/devcontainers-contrib/features/poetry:2": {}
},
"customizations": {
"vscode": {
Expand All @@ -48,12 +44,15 @@
// Uncomment the next line if you want to keep your containers running after VS Code shuts down.
// "shutdownAction": "none",

"initializeCommand": "make prepare",

// Uncomment the next line to run commands after the container is created.
"postCreateCommand": "make prepare"
"postCreateCommand": "make install"

// Configure tool-specific properties.
// "customizations": {},


// Uncomment to connect as an existing user other than the container default. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "devcontainer"
}
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ DEBUG:=True
BACKEND_SERVER_HOST:=127.0.0.1
BACKEND_SERVER_PORT:=8000
BACKEND_SERVER_WORKERS:=4
BACKEND_SERVER_VERSION:=v0.1.13
BACKEND_SERVER_VERSION:=v0.1.15
TIMEZONE:="UTC"

# Database - Postgres
Expand Down
8 changes: 4 additions & 4 deletions backend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ WORKDIR /app

ENV PYTHONDONTWRITEBYTECODE 1
ENV PYTHONUNBUFFERED 1
ENV VIRTUAL_ENV=/opt/venv
# ENV VIRTUAL_ENV=/opt/venv

# Switch on virtual environment
RUN python3 -m venv $VIRTUAL_ENV
ENV PATH="$VIRTUAL_ENV/bin:$PATH"
# RUN python3 -m venv $VIRTUAL_ENV
# ENV PATH="$VIRTUAL_ENV/bin:$PATH"

# Install system dependencies
# netcat for nc command
Expand All @@ -22,7 +22,7 @@ RUN apt-get update \

COPY . .

RUN pip3 --disable-pip-version-check --no-cache-dir install -r requirements.txt && rm -rf /tmp/pip-tmp
RUN pip --disable-pip-version-check --no-cache-dir install -r requirements.txt && rm -rf /tmp/pip-tmp

EXPOSE 8000

Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ services:

rebel:
container_name: rebel
image: ghcr.io/skywardai/rebel:v0.1.5
image: ghcr.io/skywardai/rebel:v0.1.6
restart: always
expose:
- 80
Expand Down

0 comments on commit bf1e777

Please sign in to comment.