Added primitive support for llvm-cov -path-equivalence. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigorye
commented
Oct 6, 2023
lib/slather/coverage_info.rb
Outdated
| source_file_pathname.realpath.relative_path_from(Pathname("./").realpath) | ||
| test_path=source_file_pathname | ||
| if ENV["COVERAGE_PATH_EQUIVALENCE"] | ||
| test_path=Pathname("." + "#{source_file_pathname}".delete_prefix(ENV["COVERAGE_PATH_EQUIVALENCE"].delete_suffix(",."))) |
There was a problem hiding this comment.
This only supports COVERAGE_PATH_EQUIVALENCE=XXX,., i.e. relocation from a given source root (XXX) to the current directory.
grigorye
changed the title
grigorye
force-pushed
the
feature/Path-Equivalence
branch
from
1b102c1 to
0626201
Compare
grigorye
force-pushed
the
feature/Path-Equivalence
branch
from
0626201 to
be06263
Compare
|
i think this might address #531? seems like a similar issue where the source file absolute paths are different at the time slather is run than when the tests were run. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This illustrates the idea of the functionality that we miss. The corresponding issue: #548.