Field overlay view layer for keep in/out zones #915
+262
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shueja
requested changes
Nov 12, 2024
| @@ -242,6 +242,17 @@ class FieldOverlayRoot extends Component<Props, State> { | |||
| <FieldImage2024 /> | |||
| </> | |||
| )} | |||
|
|
|||
| {layers[ViewLayers.FieldOverlays] && | |||
| doc.pathlist.activePath.params.constraints.map((c) => { | |||
There was a problem hiding this comment.
Can this be just the enabled constraints, and additionally filter out the one that's selected (if any)?
| uiState.layers[ViewLayers.Waypoints] && | ||
| uiState.isNavbarWaypointSelected() && | ||
| !this.props.selected | ||
| ? "rosybrown" |
There was a problem hiding this comment.
Not sure I like this color, but that's not a blocker.
src/document/UIData.tsx
Outdated
| }, | ||
| FieldOverlays: { | ||
| index: 6, | ||
| name: "FieldOverlays", |
There was a problem hiding this comment.
This naming is too vague and inconsistent with internal naming as well (everything is considered an Overlay).
|
Clicking a zone in the non-selected layer does not select it. If this is intentional, it's an unexpected break from existing UI norms within the app. If you're going to implement this, keep in mind that a click and drag on the non-selected zone will be hard to catch, since it will be on a different element than the one with the drag handler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.