Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Create Basic CLIs #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

wilson-ben
Copy link
Contributor

Adding C++ CLIs with functionality. They have not been implemented within Surface Toolbox yet.

I still need to update XML files and extension settings.

Copy link
Member

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i posted few comments.

It may also worth looking into implementing CLI using approach like this one:

We could even streamling the parsing of argument using https://github.com/commontk/ctk-cli doing something like this:

from ctk_cli import CLIArgumentParser

def main(args):
  [...]

if __name__ == "__main__":
   main(CLIArgumentParser().parse_args())

similar approach used in https://github.com/DigitalSlideArchive/HistomicsTK/blob/06aba476ea83da672b9ab59cc9b6caa43524cb04/histomicstk/cli/NucleiDetection/NucleiDetection.py

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Cleaner/CMakeLists.txt Outdated Show resolved Hide resolved
Cleaner/CMakeLists.txt Outdated Show resolved Hide resolved
Cleaner/CMakeLists.txt Outdated Show resolved Hide resolved
Cleaner/Cleaner.cxx Outdated Show resolved Hide resolved
Cleaner/Cleaner.cxx Outdated Show resolved Hide resolved
Cleaner/Cleaner.cxx Outdated Show resolved Hide resolved
Cleaner/Cleaner.cxx Outdated Show resolved Hide resolved
Cleaner/Cleaner.xml Outdated Show resolved Hide resolved
@wilson-ben
Copy link
Contributor Author

Have you removed extension meta-information intentionally?

Yes, I removed it for now. I might change it later

@jcfr
Copy link
Member

jcfr commented Dec 21, 2021

Rebased against master (as of Dec 21 2021) to include c++ sources of CLI originally contributed in e9602ca but not yet available in the SurfaceToolbox:

AlignMesh
AlignMeshICP
applyVec
avgMesh
closestPoint
extractVertices
GetCurvatures
GetDirectionFeatures
ImportFromFile
InvVect
KWMToPolyData
lookupPointData
pointDataOP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants