Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add streamline concatenation script #150

Conversation

jhlegarreta
Copy link
Contributor

Add streamline concatenation script and the necessary methods into the appropriate module.

@jhlegarreta
Copy link
Contributor Author

These 2 scripts may be doing exactly what is proposed here:
https://github.com/SlicerDMRI/whitematteranalysis/blob/master/bin/wm_append_clusters_to_anatomical_tracts.py
https://github.com/SlicerDMRI/whitematteranalysis/blob/master/bin/wm_append_clusters.py

Maybe they can be refactored so that the "append" operation can be reused across modules.

@jhlegarreta jhlegarreta marked this pull request as draft September 14, 2023 16:16
Add streamline concatenation script and the necessary methods into the
appropriate module.
@jhlegarreta jhlegarreta force-pushed the AddStreamlineConcatenationScript branch from 4b75d3a to cdbbfbe Compare September 15, 2023 20:30
@jhlegarreta
Copy link
Contributor Author

OK, so wm_append_clusters.py does this job (thanks Fan); the point-wise data is also preserved; the only scalar that is not preserved is the cluster idx, which is generated again and considers each tractogram as one cluster (whereas each input tractogram may contain different clusters). Refactoring the concatenation/append operation into a method is left for future work. So closing the PR for now.

@jhlegarreta jhlegarreta deleted the AddStreamlineConcatenationScript branch September 19, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant