Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix WM diffusion measurement Python script call for Linux #156

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

jhlegarreta
Copy link
Contributor

  • ENH: Add executable flag to ORG atlas application script
  • BUG: Fix WM diffusion measurement Python script call for Linux

Add executable flag to ORG atlas application script: change permissions
from `100644` to `100755`.
Fix the WM diffusion measurement Python script call in the ORG atlas
application shell script for Linux.

As described in
https://discourse.slicer.org/t/no-csv-file-in-diffusionmessurements-folder-in-wma/28439

the solution for Linux requires providing the Python script with the
path to the 3D Slicer executable together with the `--launch` option and
the path to the tract measurement 3D Slicer CLI executable as the last
positional argument.
else
measurement_cli_cmd=$FiberTractMeasurementsCLI
fi

echo "<wm_apply_ORG_atlas_to_subject> Report diffusion measurements of fiber clusters."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here has used a tab instead of whitespaces, hence the difference with the newly added code.

@jhlegarreta
Copy link
Contributor Author

Checked locally on Linux, fixes the issue.

Copy link
Member

@ljod ljod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ljod ljod merged commit e1b19a0 into SlicerDMRI:master Sep 21, 2023
1 check passed
@jhlegarreta jhlegarreta deleted the FixShellWMMeasurementLinuxCall branch September 21, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants