-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Relocate contents in test_run.py
to tests
#176
ENH: Relocate contents in test_run.py
to tests
#176
Conversation
Add missing test for `wm_cluster_remove_outliers.py` script. Left behind in commit cf5ddd8.
Relocate contents in `test_run.py` to the appropriate tests: - The file is removed, and thus removed from the scripts list in `setup.py`. - The relocated contents are commented out as no testing data exists yet. Allows tests to pass. Fixes: ``` ==================================== ERRORS ==================================== _____________________ ERROR collecting testing/test_run.py _____________________ (...) testing/test_run.py:17: in <module> wm_quality_control_tractography.main() bin/wm_quality_control_tractography.py:56: in main exit() /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/_sitebuiltins.py:26: in __call__ raise SystemExit(code) E SystemExit: None ------------------------------- Captured stdout -------------------------------- Importing whitematteranalysis package. <wm_quality_control_tractography.py> Starting... <wm_quality_control_tractography.py> Error: Input directory input_tractography/ does not exist. ``` raised for example in: https://github.com/SlicerDMRI/whitematteranalysis/actions/runs/6499690724/job/17653542925?pr=157#step:6:849
PR #173 should be merged before this one. Tests will still fail because there is an error unrelated to the tests and having to do with the version of
raised for exampled in This is addressed in |
Further test cases can be imported from PR #74 in a separate PR. |
wm_cluster_remove_outliers.py
scripttest_run.py
to tests