ENH: Improve importing optional packages and modules #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this was done for cases where there is no display system, but this can be achieved otherwise. Anyways, maybe we can keep the logic in this PR and remove the optional package import attempt and make it non-optional in a future PR as other aspects get improved. |
jhlegarreta
force-pushed
the
ImproveImportingOptPackages
branch
2 times, most recently
from
dd11ef0 to
3673dbd
Compare
Improve importing optional packages and modules: - Add helper classes and utils to take care of trying to import optional packages, and to provide meaningful information when such packages cannot be imported. - Add the corresponding tests. Prefer using all lowercases for the flags that contain the package/module import success value. Move the `whitematteranalysis/utils.py` module to the `whitematteranalysis/utils/utils.py` module to avoid package name clashes.
jhlegarreta
force-pushed
the
ImproveImportingOptPackages
branch
from
3673dbd to
91fde8d
Compare
|
Closed inadvertently. Opened PR #195. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve importing optional packages and modules:
Prefer using all lowercases for the flags that contain the package/module import success value.