STYLE: Prefer using f-strings #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
TransitionTofStrings
branch
from
bbd5d02 to
6ba311e
Compare
jhlegarreta
force-pushed
the
TransitionTofStrings
branch
from
6ba311e to
2ea26a8
Compare
jhlegarreta
commented
Nov 30, 2023
| print(fields) | ||
|
|
||
| clusters = stats.to_numpy()[:, 0] | ||
| clusters = [os.path.basename(filepath).replace('.vtp', '').replace('.vtk', '').strip() for filepath in clusters] | ||
| print() | ||
| print('Fiber clusters per subject: (n=%d): ' % len(clusters)) | ||
| print(f'Fiber clusters per subject: (n={len(clusters)}): ') | ||
|
|
||
| if len(clusters) == 800 and len(tracts) == 73: | ||
| comm_clusters = [3, 8, 33, 40, 46, 52, 56, 57, 62, 68, 69, 73, 86, 91, 109, 110, 114, 142, 144, 145, 146, 159, 163, 250, 251, 252, 257, 262, 263, 268, 271, 305, 311, 314, 322, 330, 334, 338, 342, 350, 363, 371, 375, 403, 410, 437, 440, 448, 456, 465, 468, 475, 484, 485, 488, 519, 522, 525, 543, 545, 549, 557, 576, 577, 582, 587, 591, 597, 601, 614, 620, 623, 627, 633, 645, 653, 658, 663, 670, 677, 683, 702, 770, 781] |
There was a problem hiding this comment.
These should not be hard-coded here; they should be in a separate file so that
- they can be located easily.
- they can be reused by other scripts, if necessary.
- if they need to be changed, this can be done easily in a place that contains only data-/atlas-related labels, and does not pollute the code.
To be done in a separate PR.
jhlegarreta
force-pushed
the
TransitionTofStrings
branch
3 times, most recently
from
a29c1f3 to
9958fff
Compare
Prefer using f-strings.
jhlegarreta
force-pushed
the
TransitionTofStrings
branch
from
9958fff to
ac6040f
Compare
ljod
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer using f-strings.