Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Import joblib modules in cluster outlier removal script #226

Merged

Conversation

jhlegarreta
Copy link
Contributor

Import joblib modules in cluster outlier removal script.

Fixes:

File /bin/wm_cluster_remove_outliers.py, line 256, in main
  logtrs = Parallel(n_jobs=number_of_jobs, verbose=0)(
NameError: name 'Parallel' is not defined

Inadvertently removed in commit f66b337.

Fixes #224.

Import `joblib` modules in cluster outlier removal script.

Fixes:
```
File /bin/wm_cluster_remove_outliers.py, line 256, in main
  logtrs = Parallel(n_jobs=number_of_jobs, verbose=0)(
NameError: name 'Parallel' is not defined
```

Inadvertently removed in commit f66b337.
@jhlegarreta jhlegarreta force-pushed the ImportMissingJoblibModules branch from ea189e9 to 29af7c9 Compare January 2, 2024 10:19
@jhlegarreta
Copy link
Contributor Author

CI build failures are related to two artifacts (minimal and latest builds) having conflicting names when trying to upload pytest test results:

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

The CI builds that finish earlier than their counterparts are passing, so it is unrelated to this patch set. Will be addressed in a separate PR. Merging.

@jhlegarreta jhlegarreta merged commit d08245e into SlicerDMRI:master Jan 2, 2024
6 of 10 checks passed
@jhlegarreta jhlegarreta deleted the ImportMissingJoblibModules branch January 2, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miss modules Parallel and delayed in bin/wm_cluster_remove_outliers.py
1 participant