FRON-9 spinners for main filter dropdown #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lombardoc4
force-pushed
the
dropdown-loader
branch
from
ec9ebd3 to
78f6da7
Compare
Lombardoc4
added a commit
that referenced
this pull request
Mar 19, 2024
* feat: url updates when results change * chore: building out constructor standings for season results * refactor: utilize axios for fetch calls and include status checks to see if server is active * chore: consume standings data from server Initialize the use of standings data from the server Refactor the drivers and constructors standings ui Include results type declarations at results.d.ts Update faker data to match standings schema * refactor: add constants file and revert from axios to fetch * chore: test api standings of single race * feat: added cypress tests and ci (#14) * test: cypress setup and dropdown test * test: cypress testing branch * fix: update cypress version remove error: ``` TSError: ⨯ Unable to compile TypeScript: error TS5095: Option 'bundler' can only be used when 'module' is set to 'es2015' or later. ``` * fix: rebuild pnpm.lock * chore: updated dependencies * ci: updated ci to include cypress tests * ci: fix for prettier step in lint job --------- Co-authored-by: Pratik Borole <[email protected]> * chore: migrated husky to v9 * chore: updated dependencies * race results prototype (#17) * refactor: main filter separation of concern * chore: introduce race results data per driver * refactor: proper linting * refactor: migrate lib out of app router * chore: successfully test results endpoint * refactor: timeline and remove results endpoint instead of using the /results endpoint we will use the root, /, as the base * refactor: main filter main filters needs info from url params * fix: minor update of race timeline and season tabs * fix: commitlint subject update to support jira ticket names * FRON-10 Document site url endpoints (#18) * chore: FRON-10 main filter url navigation * chore: FRON-10 adding placeholder pages * chore: FRON-8 restructure the way atoms are populated on page load and reset (#19) * FRON-9 spinners for main filter dropdown (#20) chore: FRON-9 main filter dropdowns have a loader * fix: FRON-10 resolving issue with race and session endpoints (#21) (#24) * docs: FRON-4 jira smart commits (#25) * feat: FRON-11 showcase next upcoming event (#26) * fix: FRON-20 packages and dependencies reinstalled (#27) * fix: folder structure * chore: FRON-6 include server 422 error info on page (#29) * refactor: simplify landing page, missing imagery so improvised (#30) * style: migrate from daisyui to shadcn (#31) * refactor: FRON-40 reformat project structure and organization (#32) * feat: FRON-33 shared secret, bearer token (#33) * feat: FRON-33 shared secret used in fetch calls --------- Co-authored-by: Pratik Borole <[email protected]>
Lombardoc4
added a commit
that referenced
this pull request
Mar 19, 2024
chore: FRON-9 main filter dropdowns have a loader
Lombardoc4
added a commit
that referenced
this pull request
Jun 10, 2024
chore: FRON-9 main filter dropdowns have a loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ended up doing some file restructuring. I want it to be meaningful