Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRON-71 Disable auto deployments for production #53

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

FRON-71 Disable auto deployments for production #53

wants to merge 4 commits into from
+7 −0

Conversation

borolepratik
Copy link
Contributor

@borolepratik borolepratik commented Aug 6, 2024 •
edited
Loading

  • disabled auto-deployments from main to vercel
  • all other branches and PRs will be auto-deployed
  • testing to be done on the dev branch since that env's URL is available in CORS

@borolepratik borolepratik force-pushed the FRON-71 branch 2 times, most recently from 47fac0a to 075921e Compare August 6, 2024 05:54
@Lombardoc4
Copy link
Contributor

@borolepratik To remove complexity is it worth sticking with the dev environment for testing and then main for production. Feels like a big lift just to run a unique deployment through Vercel.
If we really want to be able to test in the vercel env before pushing to dev we can add an unprotected 'testing' branch, where a PR is not required. But last i checked we don't have protection on dev, so this is pretty much doable with dev branch as is.
Thoughts??

@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontwing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 5:17pm

@borolepratik borolepratik requested a review from Lombardoc4 August 8, 2024 03:58
@borolepratik borolepratik changed the title FRON-71 Github Actions validate before send to Vercel + set/remove origins env var on heroku dynamically FRON-71 Disable auto deployments for production Aug 12, 2024
@borolepratik borolepratik reopened this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lombardoc4 Lombardoc4 Awaiting requested review from Lombardoc4

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borolepratik @Lombardoc4