Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch statement for SummaryOrderType #3405

Merged
merged 1 commit into from
Jan 7, 2022
Merged

switch statement for SummaryOrderType #3405

merged 1 commit into from
Jan 7, 2022

Conversation

char3210
Copy link
Contributor

@char3210 char3210 commented Jan 3, 2022

am i allowed to do this

Description

future-proofing

Proposed changes

use a switch statement for SummaryOrderType

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@char3210 char3210 requested a review from a team as a code owner January 3, 2022 04:46
@TheBusyBiscuit TheBusyBiscuit merged commit 0e3bafe into Slimefun:feature/avg-and-low-timings-flags Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBusyBiscuit TheBusyBiscuit TheBusyBiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@char3210 @TheBusyBiscuit @qwertyuioplkjhgfd