Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generating geo resources every scan #3973

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

iTwins
Copy link
Contributor

@iTwins iTwins commented Sep 18, 2023

Description

OptionalInt.orElse evaluates the result even when the optional is present.

Proposed changes

replace orElse with orElseGet (which doesn't evaluate if the optional is present).

Related Issues (if applicable)

Resolves #3974

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@iTwins iTwins requested a review from a team as a code owner September 18, 2023 12:56
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Sep 18, 2023
@github-actions
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@github-actions
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 5456ab03

https://preview-builds.walshy.dev/download/Slimefun/3973/5456ab03

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBusyBiscuit TheBusyBiscuit merged commit 37681ca into Slimefun:master Sep 18, 2023
@iTwins iTwins deleted the fix/generate_geo_resources branch September 18, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geo Miner not working as expected
4 participants