Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for the 1.20 smithing table #3990

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

iTwins
Copy link
Contributor

@iTwins iTwins commented Oct 8, 2023

Description

Result slot moved so need to check version for correct slot.

Proposed changes

Make result slot adapt based on minecraft version.
Also rewrote SmithingTableListener to be similar to CraftingTableListener.
SmithItemEvent and PrepareSmithingEvent exist in 1.16.

Related Issues (if applicable)

Resolves #3975

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@iTwins iTwins requested a review from a team as a code owner October 8, 2023 01:46
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 6a4642a1

https://preview-builds.walshy.dev/download/Slimefun/3990/6a4642a1

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if there was anything I missed it's probably in tests since I'm test illiterate but otherwise 👍

@Sfiguz7 Sfiguz7 merged commit d8f150f into Slimefun:master Dec 6, 2023
10 checks passed
@iTwins iTwins deleted the fix/smithing_table branch December 6, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slimefun Items are usable in smithing table even when disabled in item.yml
3 participants