Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rate limiting issues #4042

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Dec 6, 2023

Description

This PR updates dough which includes a fix for ratelimiting issues we are having in Slimefun.
Instead of hiting the MC api constantly we use a third-party with aggressive caching (playerdb.co).

Proposed changes

update dough Slimefun/dough#217

Related Issues (if applicable)

apparently there is no open issue about this.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@J3fftw1 J3fftw1 requested a review from a team as a code owner December 6, 2023 19:12
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@J3fftw1 J3fftw1 requested a review from a team as a code owner December 6, 2023 19:19
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: d2fddbd5

https://preview-builds.walshy.dev/download/Slimefun/4042/d2fddbd5

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev WalshyDev merged commit f49d2dd into Slimefun:master Dec 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants