Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for the Sensistive Block Check #4048

Merged

Conversation

JustAHuman-xD
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD commented Dec 9, 2023

Description

A bug slipped through the craps on the sensitive blocks PR

Proposed changes

gets and then re sets the block data of the block for sensitive blocks

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@JustAHuman-xD JustAHuman-xD requested a review from a team as a code owner December 9, 2023 00:00
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Dec 9, 2023
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@JustAHuman-xD
Copy link
Contributor Author

I wouldn't say I've fully tested these changes but I made sure that it fixed the bug and that the bug was legit

Copy link
Contributor

github-actions bot commented Dec 9, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 7df7e8f1

https://preview-builds.walshy.dev/download/Slimefun/4048/7df7e8f1

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@Sfiguz7 Sfiguz7 self-assigned this Dec 9, 2023
@Sfiguz7 Sfiguz7 merged commit ae983c9 into Slimefun:master Dec 9, 2023
15 checks passed
@Sfiguz7 Sfiguz7 mentioned this pull request Dec 9, 2023
7 tasks
@WalshyDev WalshyDev mentioned this pull request Dec 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants