Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Sensitive Block Changes #4049

Merged

Conversation

JustAHuman-xD
Copy link
Contributor

Description

Fixing it is taking longer than expected so we should revert until we do get it done

Proposed changes

removing all the changes with sensitive blocks

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@JustAHuman-xD JustAHuman-xD requested a review from a team as a code owner December 9, 2023 15:04
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@Sfiguz7 Sfiguz7 self-assigned this Dec 9, 2023
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: baedb449

https://preview-builds.walshy.dev/download/Slimefun/4049/baedb449

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@Sfiguz7 Sfiguz7 merged commit 7a65ea9 into Slimefun:master Dec 9, 2023
15 checks passed
@Sfiguz7 Sfiguz7 mentioned this pull request Dec 9, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants