Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writtenbook soulbound fix #4169

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ShiftSad
Copy link

@ShiftSad ShiftSad commented Apr 10, 2024

Description

When cloning an Written Book in the crafting slot with a Writable Book, it keeps all the item data, like the SoulBound Status. With should not be intended since it "dupes it".

Proposed changes

Simply setting the soul bound status false when a book is cloned

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ShiftSad ShiftSad requested a review from a team as a code owner April 10, 2024 14:57
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@ShiftSad
Copy link
Author

This is my first pull request, if there is anything I can improve I would be glad to do so. I have already noticed the labels, next time I'll make sure to use them.

@JustAHuman-xD JustAHuman-xD added the ✨ Fix This Pull Request fixes an issue. label Apr 10, 2024
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: ccc9c4c5

https://preview-builds.walshy.dev/download/Slimefun/4169/ccc9c4c5

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants