-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ChargingBench #4184
Fix ChargingBench #4184
Conversation
- ChargingBench can now only recharge ItemStacks with 1 item.
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
...io/github/thebusybiscuit/slimefun4/implementation/items/electric/machines/ChargingBench.java
Outdated
Show resolved
Hide resolved
…n/items/electric/machines/ChargingBench.java Co-authored-by: J3fftw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I did not want to dismiss the review aaaa |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4184/cf0a9e8e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Making ChargingBench rechargeable only ItemStacks with 1 items
Proposed changes
By adding this feature addon makers can make heir own Rechargeable any item they want and not be limited to tools
Related Issues (if applicable)
Resolves #4183
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values