Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #4222

Closed
wants to merge 5 commits into from
Closed

Update README.md #4222

wants to merge 5 commits into from

Conversation

Boomer-1
Copy link

Description

updating the readme to show the current version cap of 1.20.4

Proposed changes

simply changing 1.20.x to read 1.20.4 until we update to the latest version

Related Issues (if applicable)

Checklist

  • [x ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [ x] I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

updating minecraft supported versions
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Co-authored-by: ybw0014 <[email protected]>
J3fftw1
J3fftw1 previously approved these changes Aug 13, 2024
JustAHuman-xD
JustAHuman-xD previously approved these changes Aug 14, 2024
Sfiguz7
Sfiguz7 previously approved these changes Sep 6, 2024
Copy link
Member

@Sfiguz7 Sfiguz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been hanging for so long that at this point we might as well correct it I guess

@ybw0014
Copy link
Contributor

ybw0014 commented Sep 6, 2024

need to change a line of code to make CI check pass

@Sfiguz7 Sfiguz7 dismissed stale reviews from JustAHuman-xD, J3fftw1, and themself via 9fc9789 September 6, 2024 18:41
@Sfiguz7
Copy link
Member

Sfiguz7 commented Sep 6, 2024

Wait, you mean a line of the source code, right?

@ybw0014
Copy link
Contributor

ybw0014 commented Sep 6, 2024

yeah a line of the source code

@JustAHuman-xD JustAHuman-xD requested a review from a team as a code owner September 6, 2024 23:34
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: cc53a8c

https://preview-builds.walshy.dev/download/Slimefun/4222/cc53a8c1

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@ybw0014
Copy link
Contributor

ybw0014 commented Sep 12, 2024

This can be closed when #4186 is merged.

@ybw0014
Copy link
Contributor

ybw0014 commented Sep 15, 2024

this can be closed

@WalshyDev
Copy link
Member

Ez

@WalshyDev WalshyDev closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants