-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Api] Hologram Service Update #4255
base: master
Are you sure you want to change the base?
[Api] Hologram Service Update #4255
Conversation
Your Pull Request was automatically labelled as: "🔧 API" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4255/5af1692b
|
@@ -316,6 +316,7 @@ machines: | |||
HOLOGRAM_PROJECTOR: | |||
enter-text: '&7Please enter your desired Hologram Text into your Chat. &r(Color Codes are supported!)' | |||
inventory-title: 'Hologram Editor' | |||
broken: '&cThe Hologram Projector you were editing has been broken, your message has been ignored.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that a new translation key is needed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Description
There are a number of known issues with the current Hologram Service as well as a few that I found while making this PR.
I'm making this PR to update the hologram service to use text displays in 1.19.4+ and to just revamp the outdated system.
Replaces #4197
Proposed changes
Related Issues (if applicable)
#3176
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values