Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EnumMap and EnumSet usages #4258

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

md5sha256
Copy link
Contributor

Description

Removes usages of EnumMap and EnumSet on types which implement Keyed

Proposed changes

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@md5sha256 md5sha256 requested a review from a team as a code owner November 9, 2024 21:36
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Nov 9, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: fdfa003

https://preview-builds.walshy.dev/download/Slimefun/4258/fdfa0034

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev WalshyDev merged commit 47092df into Slimefun:walshy/mc-1.21 Nov 9, 2024
13 checks passed
ybw0014 added a commit to ybw0014/Slimefun4 that referenced this pull request Nov 12, 2024
gurrrrrrett3 pushed a commit to CraftYourTown/Slimefun4 that referenced this pull request Nov 23, 2024
gurrrrrrett3 pushed a commit to CraftYourTown/Slimefun4 that referenced this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants