fix(crafter): prevent using sf item in crafter (#948)

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/Slimefun.java

@@ -88,6 +88,7 @@
 import io.github.thebusybiscuit.slimefun4.implementation.listeners.crafting.CraftingTableListener;
 import io.github.thebusybiscuit.slimefun4.implementation.listeners.crafting.GrindstoneListener;
 import io.github.thebusybiscuit.slimefun4.implementation.listeners.crafting.SmithingTableListener;
+import io.github.thebusybiscuit.slimefun4.implementation.listeners.crafting.VanillaCrafterListener;
 import io.github.thebusybiscuit.slimefun4.implementation.listeners.entity.BeeListener;
 import io.github.thebusybiscuit.slimefun4.implementation.listeners.entity.EntityInteractionListener;
 import io.github.thebusybiscuit.slimefun4.implementation.listeners.entity.FireworksListener;
@@ -708,6 +709,7 @@ private void registerListeners() {
         new BeeWingsListener(this, (BeeWings) SlimefunItems.BEE_WINGS.getItem());
         new PiglinListener(this);
         new SmithingTableListener(this);
+        new VanillaCrafterListener(this);
         new JoinListener(this);
 
         // Item-specific Listeners

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/crafting/SlimefunCraftingListener.java

@@ -31,4 +31,17 @@ default boolean isUnallowed(@Nullable ItemStack item) {
     default boolean isUnallowed(@Nullable SlimefunItem item) {
         return item != null && !(item instanceof VanillaItem) && !item.isDisabled();
     }
+
+    default boolean isCraftingUnallowed(@Nullable ItemStack item) {
+        if (item == null) {
+            return false;
+        }
+
+        SlimefunItem sfItem = SlimefunItem.getByItem(item);
+        return isCraftingUnallowed(sfItem);
+    }
+
+    default boolean isCraftingUnallowed(@Nullable SlimefunItem item) {
+        return item != null && !item.isUseableInWorkbench();
+    }
 }

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/crafting/VanillaCrafterListener.java

@@ -0,0 +1,55 @@
+package io.github.thebusybiscuit.slimefun4.implementation.listeners.crafting;
+
+import city.norain.slimefun4.compatibillty.VersionedEvent;
+import io.github.thebusybiscuit.slimefun4.api.items.SlimefunItem;
+import io.github.thebusybiscuit.slimefun4.implementation.Slimefun;
+import javax.annotation.Nonnull;
+import org.bukkit.block.Crafter;
+import org.bukkit.entity.Player;
+import org.bukkit.event.Event;
+import org.bukkit.event.EventHandler;
+import org.bukkit.event.inventory.InventoryAction;
+import org.bukkit.event.inventory.InventoryClickEvent;
+import org.bukkit.event.inventory.InventoryMoveItemEvent;
+import org.bukkit.event.inventory.InventoryType;
+import org.bukkit.inventory.Inventory;
+
+public class VanillaCrafterListener implements SlimefunCraftingListener {
+    public VanillaCrafterListener(@Nonnull Slimefun plugin) {
+        plugin.getServer().getPluginManager().registerEvents(this, plugin);
+    }
+
+    @EventHandler(ignoreCancelled = true)
+    public void onCrafter(InventoryClickEvent e) {
+        Inventory clickedInventory = e.getClickedInventory();
+        Inventory topInventory = VersionedEvent.getTopInventory(e);
+
+        if (clickedInventory != null
+                && topInventory.getType() == InventoryType.CRAFTER
+                && topInventory.getHolder() instanceof Crafter
+                && e.getWhoClicked() instanceof Player player) {
+
+            if (e.getAction() == InventoryAction.HOTBAR_SWAP) {
+                e.setCancelled(true);
+                return;
+            }
+
+            if (clickedInventory.getType() == InventoryType.CRAFTER) {
+                e.setCancelled(isCraftingUnallowed(SlimefunItem.getByItem(e.getCursor())));
+            } else {
+                e.setCancelled(isCraftingUnallowed(SlimefunItem.getByItem(e.getCurrentItem())));
+            }
+
+            if (e.getResult() == Event.Result.DENY) {
+                Slimefun.getLocalization().sendMessage((Player) e.getWhoClicked(), "crafter.not-working", true);
+            }
+        }
+    }
+
+    @EventHandler
+    public void hopperOnCrafter(InventoryMoveItemEvent e) {
+        if (e.getDestination().getType() == InventoryType.CRAFTER && isCraftingUnallowed(e.getItem())) {
+            e.setCancelled(true);
+        }
+    }
+}

src/main/resources/languages/en/messages.yml

@@ -363,6 +363,9 @@ workbench:
 cauldron:
   no-discoloring: '&4You cannot discolor Slimefun Armor'
 
+crafter:
+  not-working: '&4You cannot use a Slimefun item in crafter!'
+
 gps:
   deathpoint: '&4Deathpoint &7%date%'
   status-online: 'ONLINE'

src/main/resources/languages/zh-CN/messages.yml

@@ -350,6 +350,8 @@ workbench:
   not-enhanced: '&4你不能在普通的工作台上使用 Slimefun 物品'
 cauldron:
   no-discoloring: '&4你不能用炼药锅洗去 Slimefun 物品的颜色'
+crafter:
+  not-working: '&4你不能在合成机上用 Slimefun 物品合成'
 gps:
   deathpoint: '&4死亡点 &7%date%'
   status-online: '在线'