Bugfix so authorizationcode flow is supported. #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used inheritance to minimize code changes, Liskuv subsitution is used here
Created a new component, so working open/closed principle is used. Other browsers and flows are not impacted
Added logging, so you see to what location you are directed and if you get an error from the IDP, you can see it.
Added some
@Override
tags, so methods could be overwritten.Made a
public final static DEFAULT_ERROR_PAGE
private and made agetDefaultErrorPage
, so an other default error page can be made with somewhat more specific information ( but honostly, after adding the soapui log, this is not needed)No support yet for authrizationcode +pkce, because my java is not what it should be. :) But good enough to suggest this fix.
No tests created, it is only a new userinterface browsercomponent that was changed. Did test it manually with auth0.com
Linked issue:
#754