Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix so authorizationcode flow is supported. #755

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

kriebb
Copy link

@kriebb kriebb commented Oct 31, 2022

  • Used inheritance to minimize code changes, Liskuv subsitution is used here

  • Created a new component, so working open/closed principle is used. Other browsers and flows are not impacted

  • Added logging, so you see to what location you are directed and if you get an error from the IDP, you can see it.

  • Added some @Override tags, so methods could be overwritten.

  • Made a public final static DEFAULT_ERROR_PAGE private and made a getDefaultErrorPage, so an other default error page can be made with somewhat more specific information ( but honostly, after adding the soapui log, this is not needed)

  • No support yet for authrizationcode +pkce, because my java is not what it should be. :) But good enough to suggest this fix.

  • No tests created, it is only a new userinterface browsercomponent that was changed. Did test it manually with auth0.com

  • Linked issue:

#754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant