Address review feedback

SmartThingsCommunity · Dec 10, 2024 · 60e1d59 · 60e1d59
1 parent da20fa0
commit 60e1d59
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/drivers/SmartThings/matter-lock/src/init.lua b/drivers/SmartThings/matter-lock/src/init.lua
@@ -580,9 +580,7 @@ local function do_configure(driver, device)
     profile_name = profile_name .. "-nobattery"
     device.log.info(string.format("Updating device profile to %s.", profile_name))
     device:try_update_metadata({profile = profile_name})
-  end
-
-  if #battery_feature_eps > 0 then
+  else
     local req = im.InteractionRequest(im.InteractionRequest.RequestType.READ, {})
     req:merge(clusters.PowerSource.attributes.AttributeList:read())
     device:send(req)

diff --git a/drivers/SmartThings/matter-sensor/src/init.lua b/drivers/SmartThings/matter-sensor/src/init.lua
@@ -315,13 +315,6 @@ end
 local function info_changed(driver, device, event, args)
   if device.profile.id ~= args.old_st_store.profile.id then
     set_boolean_device_type_per_endpoint(driver, device)
-    for cap_id, attributes in pairs(subscribed_attributes) do
-      if device:supports_capability_by_id(cap_id) then
-        for _, attr in ipairs(attributes) do
-          device:add_subscribed_attribute(attr)
-        end
-      end
-    end
     device:subscribe()
   end
   if not device.preferences then