Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAD-11890: Switch Driver fails to profile color temperature lights if paired with an onoff device type #1019

Conversation

Con-Tejus
Copy link
Contributor

ticket: https://smartthings.atlassian.net/browse/CHAD-11890

Not Working

color temperature light
  DeviceType { id: 268, revision: 1 }, 
onoff
  DeviceType { id: 256, revision: 1 }, 
bridged device
  DeviceType { id: 19, revision: 1 }],

Working 

color temperature light
  DeviceType { id: 268, revision: 1 }, 
bridged device
  DeviceType { id: 19, revision: 1 }]

Bug Description

  • Current matter switch fingerprinting fails to accurately fingerprint a color temperature light if it also contains support for an onoff device type. In the example above, the working device would be fingerprinted to light-level-colorTemperature where as the not working device would fingerprint to light-binary.

How/When it Happens

  • When onboarding a matter light which only contains support for a color temperature light and onoff light. Bridged device type won’t effect this.

User Impact

  • The user would only have onoff functionality and dimming won’t be available.

Options/Chosen Solution

  • We can include an additional fingerprint including the onoff device
  • We can move the existing color temperature light fingerprint above the onoff finger print since fingerprints are ordered in priority.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Channel deleted.

@github-actions
Copy link

Test Results

     54 files  ±0     345 suites  ±0   0s ⏱️ ±0s
1 622 tests ±0  1 622 ✔️ ±0  0 💤 ±0  0 ±0 
2 842 runs  ±0  2 842 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit b381889. ± Comparison against base commit ee9e72b.

@github-actions
Copy link

File Coverage
All files 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against b381889

@Con-Tejus
Copy link
Contributor Author

Tested on Kianoosh's hub with the problem device and it now has support for dimmer functionality

image

@Con-Tejus Con-Tejus merged commit 38a73d2 into main Oct 17, 2023
10 checks passed
@Con-Tejus Con-Tejus deleted the CHAD-11890-switch-fingerprint-fails-to-profile-color-temperature-light branch October 17, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants