Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fingerprint add for the Zemismart Thread Smart Switch 4 MT606-4 #1036

Closed
wants to merge 4 commits into from
Closed

Fingerprint add for the Zemismart Thread Smart Switch 4 MT606-4 #1036

wants to merge 4 commits into from

Conversation

lelandblue
Copy link
Contributor

WWST Cert Submission for the Zemismart Thread Smart Switch 4 MT606-4 through the Edge Driver Builder

@lelandblue lelandblue requested review from hubTab and z-michel October 24, 2023 21:25
@github-actions
Copy link

Test Results

     54 files  ±0     345 suites  ±0   0s ⏱️ ±0s
1 622 tests ±0  1 622 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 842 runs  ±0  2 842 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 697d635. ± Comparison against base commit 42158ec.

@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Test Results

   55 files  + 1    352 suites  +7   0s ⏱️ ±0s
1 645 tests +23  1 645 ✅ +23  0 💤 ±0  0 ❌ ±0 
2 890 runs  +48  2 890 ✅ +48  0 💤 ±0  0 ❌ ±0 

Results for commit 16f9df7. ± Comparison against base commit 42158ec.

This pull request removes 8 and adds 31 tests. Note that renamed tests count towards both. 
Battery percentage report should be handled Popp
Handle a held event in a multi-press sequence
Heating setpoint reports are handled Popp
Temperature reporting should create the appropriate events Popp
Thermostat cooling setpoint reporting should not create setpoint events, the mode is not supported Popp
Thermostat heating setpoint reporting should create the appropriate events Popp
an attribute read should not be sent after 30s if there is a response
an attribute read should not be sent after 30s if there is a response another timing

Check when the device is removed
Command success should result in opening/closing event
Configuration report indicating code deletion should be handled
First child device: switch capability switch should send the appropriate commands
Handle Lock cmd
Handle a long press including MultiPressComplete
Handle long press followed by single press
Handle turnOffIndicator in infochanged
Handle turnOffIndicatorLight in infochanged : Off
Handle turnOffIndicatorLight in infochanged : On
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

File Coverage
All files 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 97% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 16f9df7

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Channel deleted.

@lelandblue lelandblue requested a review from ctowns February 6, 2024 19:58
lelandblue
lelandblue commented Feb 6, 2024
View reviewed changes
drivers/SmartThings/matter-switch/fingerprints.yml Outdated
deviceLabel: "Zemismart Thread Smart Switch"
vendorId: 0x139C
productId: 0xAA01
deviceProfileName: "switch-4"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This profile assignment needs to change to support parent child

@lelandblue
Changing profile assignment
442d9ad 
The original commit had this device profile to be switch-4, however, this profile is not parent-child. I have edited this PR to reflect a parent-child profile instead.
@lelandblue lelandblue closed this Jun 13, 2024
@lelandblue
Copy link
Contributor Author

The partner has cancelled the certification for this device, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubTab hubTab hubTab approved these changes

@ctowns ctowns ctowns approved these changes

@greens greens greens approved these changes

@z-michel z-michel Awaiting requested review from z-michel

Assignees
No one assigned
Labels
do not merge Edge Builder Tool WWST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lelandblue @greens @ctowns @hubTab