Rolling up main to beta #1084
Merged
Rolling up main to beta #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Nuki SmartLock Pull Request Adding this profile and fingerprint for Nuki Matter Smart Lock WWST Certification. * Rename * Update fingerprints.yml Updating device profile name and removed extra space * Update and rename lock-without-codes-or-tamper.yml to lock-nocodes-notamper Updated filename and Name field with lock-nocodes-notamper * Rename lock-nocodes-notamper to lock-nocodes-notamper.yml added .yml to filename --------- Co-authored-by: lelandblue <[email protected]>
* Nuki Smart Lock Pro Adding Profile and Fingerprint for Nuki Pro version of Matter Smart Lock - WWST Certification * Rename * Test rename * Correctly Renamed * Delete drivers/SmartThings/matter-lock/profiles/lock-without-codes-or-tamper.yml This is a duplicate profile * Change the profile lock-nocodes-notamper Update the PR to the lock-nocodes-notamper profile, since the one originally in the commit was a dupe profile. --------- Co-authored-by: lelandblue <[email protected]>
Signed-off-by: WangShao <[email protected]>
Fixes a recent issue that has arisen with deployment in CN
The On/Off Light switch device type requires bindings in order to work correctly because the On/Off cluster on this device type is client type as specified in the matter spec. Because we do not support bindings, we have removed the generic fingerprint for this device type so that it will join as a matter-things so we do not expose broken funcitonality to users. However, we have found some devices that do not follow the spec and report an On/Off Light Switch device type and yet have a server type OnOff cluster. These out-of-spec devices would technically have worked before we decided to remove the fingerprints due to lack of binding support, so these devices will be broken now that they will join as matter-thing. This adds a workaround that allows us to check for a special case where a matter-thing supports the OnOff cluster as a server, and then we switch to the switch-binary profile. Additionally, this improves our multi-switch profile switching logic to only count server type On/Off cluster endpoints towards the switch total for the same reasons as described above.
Checks if device supports any supported capabilities other than refresh. If the profile just supports refresh, assume the device is a matter-thing.
…thing-to-switch Support switching from matter-thing to switch-binary
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
|
matter-lock_coverage.xml
matter-switch_coverage.xml
zigbee-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7815132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.