aeotec heavy duty switch added #1109
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 55 files 353 suites 0s ⏱️ Results for commit d1750a9. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d1750a9 |
| defaults.register_for_default_handlers(driver_template, driver_template.supported_capabilities) | ||
| local ge_switch = ZwaveDriver("aeotec-heavy-duty", driver_template) | ||
| ge_switch:run() |
There was a problem hiding this comment.
because this is a dub-driver, you need to define a can_handle function and should not be registering for defaults
|
Hey @ronie-z-wave Please see the comments made on this PR and include the changes requested at your nearest opportunity to help move this forward, thank you! |
|
|
| local ZwaveDriver = require "st.zwave.driver" | ||
| local defaults = require "st.zwave.defaults" |
There was a problem hiding this comment.
drivers/SmartThings/zwave-switch/src/aeotec-heavy-duty/init.lua:18:7: (W211) unused variable ZwaveDriver
drivers/SmartThings/zwave-switch/src/aeotec-heavy-duty/init.lua:19:7: (W211) unused variable defaults
There was a problem hiding this comment.
Ah sorry. I will remove them.
…ve-mke/SmartThingsEdgeDrivers into add/aeotec_heavy_duty_switch
There was a problem hiding this comment.
Either change the copyright date or add back in the credit to the dev.
There was a problem hiding this comment.
Sorry. I should have mentioned this before, but for devices like this, you can just use one fingerprint.
- id: "Aeotec/Heavy Duty"
deviceLabel: Aeotec Heavy Duty
manufacturerId: 0x0086
productId: 0x004E
deviceProfileName: aeotec-heavy-duty
And you can similarly leave out the product type in the preferences and can_handle sections of the code. Empty fields are treated as wildcards for the matching functions.
For example, here's another aeotec switch where we do this: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zwave-switch/fingerprints.yml#L356
|
I would just leave a comment next to the fingerprint indicating it covers the US, EU, and AU versions. |
|
Closing this pr because #1325 was merged. Thank you. |
No description provided.