-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Resideo Korea DT300ST-M0000 Thermostat #1119
add Resideo Korea DT300ST-M0000 Thermostat #1119
Conversation
Duplicate profile check: Passed - no duplicate profiles detected. |
Channel deleted. |
Test Results 55 files 353 suites 0s ⏱️ Results for commit 22c8638. ♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 22c8638 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think you could include a test that works with one of the child devices? Here's an example of how this can be done in zigbee: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zigbee-switch/src/test/test_wallhero_switch.lua
I've updated the pull request to include unit tests for each child device as you suggested. These tests should provide better coverage and ensure the functionality of the child devices. Please let me know if there are any further changes or improvements needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you.
Resideo Korea Thermostat for WWST