Rolling up beta to production #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current way we parse the SSDP response headers can cause failures in discovering Sonos speakers with unicode characters that require more than one byte for their representation, such as CJK characters. The current parsing patterns use the '`%g`' character class, which does not parse characters that don't fit in a single byte; while Lua itself is utf-8 compatible and it is safe to use multi-code-point graphemes or clusters in Lua strings, the actual string library is byte-oriented for many operations and the pattern used currently tries to match each byte against the provided class. '`.-`' works here instead, as it matches all bytes in a non-greedy way (akin to '`.*?`' in PCRE).
Add profile to support 6-button matter button devices. This means 6-button devieces will be supported as MCD rather than parent-child.
…on-profile Matter Button: add 6-button static profile support
Previous approach could have potentially accepted invalid headers. This tweaks the parsing pattern to fail to find headers that don't coform to the actual accepted structure of a header key.
…y-non-ascii-name-failure
Rolling up main to beta
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
|
matter-button_coverage.xml
zwave-smoke-alarm_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 308acfe |
cjswedes
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.