Feature/eve performance device off #1125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't the power reports of the device if the device is off - In the timer, we now check if the device is off using device:get_latest_state() - Set the power to 0 before the read is skipped so that the power is correctly displayed and not using a stale value
- Add unit test to test the on attribute
- Create the 1-minute timer when the device is switched on (if the timer doesn't exist yet) - Delete the 1-minute timer when the device is turned off - The totle consumption is saved in the variable LATEST_TOTAL_CONSUMPTION_WH - There is now a 15-minutes timer to send the powerConsumptionReport report to satisfy the ST energy requirement
Add one unit test
|
Channel deleted. |
Test Results 55 files ±0 347 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit a95a3ed. ± Comparison against base commit ff48787. This pull request removes 7 and adds 1 tests. Note that renamed tests count towards both. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a95a3ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.