Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAD-12259 zigbee motion: high battery usage #1142

Merged
merged 1 commit into from
Jan 30, 2024
Merged

CHAD-12259 zigbee motion: high battery usage #1142

merged 1 commit into from
Jan 30, 2024

Conversation

greens
Copy link
Contributor

@greens greens commented Jan 3, 2024

Users reported higher battery consumption with edge drivers and a disparity was noted between DTH and driver cluster configurations. A forthcoming change in the lua libraries will change the defaults, but this change should significantly improve the situation for most users in the meantime with a simple refresh. Changes the IAS Zone reporting configuration to use the device defaults and changes temperature reporting to a max interval of 10 minutes with a 1 degree celsius reporting threshold.

@greens greens requested review from tpmanley and cjswedes January 3, 2024 20:21
Copy link

github-actions bot commented Jan 3, 2024

Test Results

   55 files    352 suites   0s ⏱️
1 645 tests 1 645 ✅ 0 💤 0 ❌
2 890 runs  2 890 ✅ 0 💤 0 ❌

Results for commit 352d768.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 3, 2024

zigbee-contact_coverage.xml

File Coverage
All files 99%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/smartsense-multi/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/multi-sensor/init.lua 97%

zigbee-motion-sensor_coverage.xml

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/smartsense-multi/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/multi-sensor/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/aqara/init.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/aqara/aqara_utils.lua 78%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/thirdreality/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/ikea/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/aqara/high-precision-motion/init.lua 69%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/gatorsystem/init.lua 98%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 352d768

@greens
Copy link
Contributor Author

greens commented Jan 3, 2024

I think I'll also be expanding this to zigbee-contact. The temperature issue isn't present, but the IAS zone one is.

Additionally, I think the monitored attribute health check might also still be a culprit even if the reporting configuration is updated. In that sense, the simple refresh from this PR should be an improvement but a rejoin will be required for a full fix, since I don't feel comfortable fully removing the monitoring of the IAS Zone attribute...

Copy link

github-actions bot commented Jan 3, 2024

Channel deleted.

@@ -45,7 +45,6 @@ local zigbee_contact_driver_template = {
},
sub_drivers = {
require("aqara"),
require("battery-overrides"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this now released in 51?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't for 51. It was just a sub-driver for one specific Visonic device. Behavior could have been captured by simply adding the model to drivers/SmartThings/zigbee-contact/src/contact-temperature-sensor/init.lua, so that's what I did.

@greens greens requested a review from wkhenon January 3, 2024 22:49
Users reported higher battery consumption with edge drivers and a disparity was noted between DTH and driver cluster configurations. A forthcoming change in the lua libraries will change the defaults, but this change should significantly improve the situation for most users in the meantime with a simple refresh. Changes the IAS Zone reporting configuration to use the device defaults and changes temperature reporting to a max interval of 10 minutes with a 1 degree celsius reporting threshold.

add change for zigbee contact as well
@greens greens merged commit 290ad7a into main Jan 30, 2024
12 checks passed
@greens greens deleted the fixup/CHAD-12259 branch January 30, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants