Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hue light controls when in sync mode #1144

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

bflorian
Copy link
Contributor

@bflorian bflorian commented Jan 3, 2024

Update Philips Hue light device profiles to reference device configurations that disable the light controls when it is in sync mode. This PR should not be merged until the device configurations have been deployed.

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jan 3, 2024

Duplicate profile check: Passed - no duplicate profiles detected.

@bflorian bflorian force-pushed the hue-light-sync-support branch from cb0c85e to 0ac94d5 Compare January 3, 2024 20:47
Copy link

github-actions bot commented Jan 3, 2024

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 0cd2002

Copy link

github-actions bot commented Jan 3, 2024

Test Results

   59 files    374 suites   0s ⏱️
1 807 tests 1 807 ✅ 0 💤 0 ❌
3 129 runs  3 129 ✅ 0 💤 0 ❌

Results for commit 0cd2002.

♻️ This comment has been updated with latest results.

@bflorian bflorian changed the title Disable hub light controls when in sync mode Disable hue light controls when in sync mode Jan 3, 2024
@bflorian bflorian force-pushed the hue-light-sync-support branch from 0ac94d5 to 491d1b0 Compare January 3, 2024 20:53
@@ -6,10 +6,6 @@ components:
version: 1
- id: switchLevel
version: 1
config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the custom presentation isn't visible in this changeset, I wanted to make a visibility comment here to call out that these embedded device configs are removed in this PR because they're rolled in to the custom presentation upon which this PR depends.

@dljsjr dljsjr force-pushed the hue-light-sync-support branch from 491d1b0 to 8fba48d Compare January 30, 2024 15:33
Copy link

github-actions bot commented Jan 30, 2024

Channel deleted.

@dljsjr dljsjr force-pushed the hue-light-sync-support branch from 8fba48d to 721f184 Compare January 31, 2024 19:05
@dljsjr
Copy link
Contributor

dljsjr commented Jan 31, 2024

Added do not merge, it was requested that we wait for some mobile app and infrastructure work before merging this.

@dljsjr dljsjr force-pushed the hue-light-sync-support branch from 721f184 to 70abf14 Compare March 14, 2024 14:17
@dljsjr dljsjr force-pushed the hue-light-sync-support branch from 70abf14 to 0cd2002 Compare March 14, 2024 15:44
Copy link

@mantiger mantiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is the last code to finalize hue music sync.
It should be included in R2 timeline so please merge it as soon as possible.

@bflorian bflorian merged commit 47aa81a into SmartThingsCommunity:main Jun 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants