(Hue/Sonos) Use new Luncheon features if available #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next Lua Libs release will include an update to the vendored dep Luncheon which has built-in support for chunked transfer encodings. Previous versions of Luncheon did not support chunked transfer so we had to roll our own in order to handle large REST API responses. We branch on the reported lua libs API version, using Luncheon directly if it's available, otherwise we continue to use the existing parsing. Supercedes: #1148 Co-authored-by: Robert Masen <[email protected]>
dljsjr
requested review from
varzac,
tandres,
FreeMasen,
elbe0046,
cjswedes and
NoahCornell
|
|
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ed3e3e7 |
|
Channel deleted. |
1 task
cjswedes
approved these changes
Jan 5, 2024
tandres
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next Lua Libs release will include an update to the vendored dep Luncheon which has built-in support for chunked transfer encodings.
Previous versions of Luncheon did not support chunked transfer so we had to roll our own in order to handle large REST API responses.
We branch on the reported lua libs API version, using Luncheon directly if it's available, otherwise we continue to use the existing parsing.
Supercedes: #1148
Co-authored-by: Robert Masen [email protected]