[Eve]: Support for Eve Energy Outlet #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Timac
commented
Jan 30, 2024
Timac
commented
- Add Eve Energy Outlet fingerprint
- Only create the polls (create_poll_schedule and create_poll_report_schedule) if the device supports capabilities.powerConsumptionReport
- When the device is initialized, create child devices with the profile plug-binary for each additional outlet
- Update component_to_endpoint, endpoint_to_component and find_child to support multiple children
- Each time an oulet is turned on or off, store the value in a dictionary
- If one of the outlet is on, we should create the poll to monitor the power consumption
- If all the outlet are off, we should delete the poll
- Add Eve Energy Outlet fingerprint
- Add Eve Energy Outlet fingerprint - Only create the polls (create_poll_schedule and create_poll_report_schedule) if the device supports capabilities.powerConsumptionReport - When the device is initialized, create child devices with the profile plug-binary for each additional outlet - Update component_to_endpoint, endpoint_to_component and find_child to support multiple children - Add a check in on_off_attr_handler to make sure the polling functions are only called for the parent device/endpoint 1, which supports powerConsumption
- Each time an oulet is turned on or off, store the value in a dictionary - If one of the outlet is on, we should create the poll to monitor the power consumption - If all the outlet are off, we should delete the poll
|
Channel deleted. |
Test Results 55 files ±0 352 suites ±0 0s ⏱️ ±0s Results for commit 321aa8b. ± Comparison against base commit d57f980. This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 321aa8b |
Only run the device_init function for the parent device.
ctowns
approved these changes
Feb 8, 2024
ctowns
pushed a commit
that referenced
this pull request
Feb 26, 2024
* Eve Energy Outlet - Add Eve Energy Outlet fingerprint * Eve Energy Outlet - Add Eve Energy Outlet fingerprint - Only create the polls (create_poll_schedule and create_poll_report_schedule) if the device supports capabilities.powerConsumptionReport - When the device is initialized, create child devices with the profile plug-binary for each additional outlet - Update component_to_endpoint, endpoint_to_component and find_child to support multiple children - Add a check in on_off_attr_handler to make sure the polling functions are only called for the parent device/endpoint 1, which supports powerConsumption * Eve Energy Outlet - Each time an oulet is turned on or off, store the value in a dictionary - If one of the outlet is on, we should create the poll to monitor the power consumption - If all the outlet are off, we should delete the poll * Remove unused log to fix luacheck * Don't change the profile, this breaks the unit tests * Eve Energy Outlet Only run the device_init function for the parent device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.