-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rolling up beta to production #1203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds line number output to failure reports from the non-ci `run_driver_tests.py` script. This script doesn't run in CI/CD but can be useful for local development since it can take the `--filter` arg, which lets developers run groups of tests at once with JUnit reports. Adding the line numbers to the `stdout` report is a QoL improvement for devs to jump to tests quickly; I've even been able to create a problem matcher for the output in VS Code now. The `run_driver_tests_p.py` script that runs in CI/CD is unmodified.
* Add AiDot Matter light * remove device --------- Co-authored-by: shenkaijie <[email protected]> Co-authored-by: lelandblue <[email protected]>
…line-number-to-local-test-script
Commands can arrive from a zigbee lock after an unlock event in any order. This can be a problem if the door lock operation event arrives _after_ the attribute report about the door lock state. Because the door lock attribute update doesn't include any useful metadata, but it arrives first, the second command with the useful metadata is marked as a duplicate and debounced, dropping all of that useful metadata on the floor. This same issue can also happen with Z-Wave, but because of the overloading of the notification defaults, it will have to be fixed via updates to the lua libraries. This fix is also going into the lua libraries, but it's easier to also deploy it quicker here.
BUG2-659 Zigbee locks: fix out-of-order commands
CN: Join name translations
Rolling up main to beta
Duplicate profile check: Passed - no duplicate profiles detected. |
Channel deleted. |
Test Results 55 files 352 suites 0s ⏱️ Results for commit df506bd. |
matter-switch_coverage.xml
zigbee-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against df506bd |
dljsjr
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.