Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rolling up beta to production #1203

Merged
merged 9 commits into from
Feb 6, 2024
Merged

rolling up beta to production #1203

merged 9 commits into from
Feb 6, 2024

Conversation

ctowns
Copy link
Contributor

@ctowns ctowns commented Feb 6, 2024

No description provided.

dljsjr and others added 9 commits January 10, 2024 12:42
This change adds line number output to failure reports from the non-ci
`run_driver_tests.py` script. This script doesn't run in CI/CD but can
be useful for local development since it can take the `--filter` arg,
which lets developers run groups of tests at once with JUnit reports.

Adding the line numbers to the `stdout` report is a QoL improvement
for devs to jump to tests quickly; I've even been able to create a
problem matcher for the output in VS Code now.

The `run_driver_tests_p.py` script that runs in CI/CD is unmodified.
* Add AiDot Matter light

* remove device

---------

Co-authored-by: shenkaijie <[email protected]>
Co-authored-by: lelandblue <[email protected]>
Commands can arrive from a zigbee lock after an unlock event in any order. This can be a problem if the door lock operation event arrives _after_ the attribute report about the door lock state. Because the door lock attribute update doesn't include any useful metadata, but it arrives first, the second command with the useful metadata is marked as a duplicate and debounced, dropping all of that useful metadata on the floor. This same issue can also happen with Z-Wave, but because of the overloading of the notification defaults, it will have to be fixed via updates to the lua libraries. This fix is also going into the lua libraries, but it's easier to also deploy it quicker here.
BUG2-659 Zigbee locks: fix out-of-order commands
@ctowns ctowns requested review from greens and dljsjr February 6, 2024 19:25
Copy link

github-actions bot commented Feb 6, 2024

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Feb 6, 2024

Channel deleted.

Copy link

github-actions bot commented Feb 6, 2024

Test Results

   55 files    352 suites   0s ⏱️
1 643 tests 1 643 ✅ 0 💤 0 ❌
2 889 runs  2 889 ✅ 0 💤 0 ❌

Results for commit df506bd.

Copy link

github-actions bot commented Feb 6, 2024

matter-switch_coverage.xml

File Coverage
All files 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 93%

zigbee-lock_coverage.xml

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/samsungsds/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/yale/init.lua 81%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua 98%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against df506bd

@lelandblue lelandblue requested a review from cjswedes February 6, 2024 19:34
@ctowns ctowns merged commit a61f19c into production Feb 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants