Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter Switch: add handling for multi-On/Off Light Switch device types #1205

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ctowns
Copy link
Contributor

@ctowns ctowns commented Feb 7, 2024

The On/Off Light Switch type supports the On/Off cluster as client, however some deviecs still report the On/Off light switch but implement On/Off cluster as server or both. There was previously a check to handle this case, but it did not account for multi-devices, so this expands the check to handle multi-devices that fall in this category as well.

The On/Off Light Switch type supports the On/Off cluster as client,
however some deviecs still report the On/Off light switch but
implement On/Off cluster as server or both. There was previously
a check to handle this case, but it did not account for
multi-devices, so this expands the check to handle multi-devices
that fall in this category as well.
Copy link

github-actions bot commented Feb 7, 2024

Channel deleted.

Copy link

github-actions bot commented Feb 7, 2024

Test Results

   55 files  ±0    352 suites  ±0   0s ⏱️ ±0s
1 645 tests ±0  1 645 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 890 runs  ±0  2 890 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b3be835. ± Comparison against base commit fcc57bd.

Copy link

github-actions bot commented Feb 7, 2024

File Coverage
All files 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 97%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against b3be835

@lelandblue lelandblue self-requested a review February 7, 2024 21:40
Copy link
Contributor

@lelandblue lelandblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was tested with SRPOL, the device parent device joined to the switch-binary profile and so did the child.

Note: The child's name will join as "Matter Thing 2" but will be functional.

@ctowns ctowns merged commit 0f9db39 into main Feb 13, 2024
11 checks passed
@ctowns ctowns deleted the bugfix/handle-multi-on-off-light-switches branch February 13, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants