Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling up beta to production #1228

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Rolling up beta to production #1228

merged 10 commits into from
Feb 20, 2024

Conversation

greens
Copy link
Contributor

@greens greens commented Feb 20, 2024

No description provided.

ctowns and others added 10 commits February 6, 2024 21:24
The On/Off Light Switch type supports the On/Off cluster as client,
however some deviecs still report the On/Off light switch but
implement On/Off cluster as server or both. There was previously
a check to handle this case, but it did not account for
multi-devices, so this expands the check to handle multi-devices
that fall in this category as well.
Using the hex values rather than the ascii characters to fix this issue

Signed-off-by: Liu Yiding <[email protected]>
Fix run_driver_tests.py UnicodeDecodeError
This change puts an API Version guard around the call that performs the
auto-add/auto-delete scan at startup, which is causing a crash on 0.47
TV's due to an issue with looking up non-existent UUID's.

We believe the root of the issue is that the non-existent UUID lookup
is related to trying to look up the Hub UUID as the parent of the bridge,
but because this is a pretty gnarly issue we're going to roll back
while we're confirming our suspicion.
* fix for driver crash issue #46
apply patches:
SolutionsEngineering/stse-edge-network-audio-example#63
SolutionsEngineering/stse-edge-network-audio-example#64

* Fix luacheck issue

---------

Co-authored-by: ADHARMAN\ChCai <[email protected]>
Co-authored-by: lelandblue <[email protected]>
* Adding Zemismart Inline Module ZME2 Device

* Add quotes around ID
…i-on-off-light-switches

Matter Switch: add handling for multi-On/Off Light Switch device types
The icon for the RemoteController category is not a button icon. This
commit changes the category for the single button profile among the
matter-button profiles from RemoteController to Button.

Signed-off-by: Youngho Yoon <[email protected]>
@greens greens requested review from dljsjr and ctowns February 20, 2024 21:21
@CLAassistant
Copy link

CLAassistant commented Feb 20, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 8 committers have signed the CLA.

✅ ctowns
✅ liuyd96
✅ cchillerr
✅ dljsjr
✅ greens
✅ lelandblue
✅ yhoyoon
❌ gharveymn
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Feb 20, 2024

Channel deleted.

Copy link

Test Results

   55 files    352 suites   0s ⏱️
1 645 tests 1 645 ✅ 0 💤 0 ❌
2 890 runs  2 890 ✅ 0 💤 0 ❌

Results for commit 2651f5c.

Copy link

matter-button_coverage.xml

File Coverage
All files 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92%

matter-switch_coverage.xml

File Coverage
All files 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 97%

zigbee-motion-sensor_coverage.xml

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/gatorsystem/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/thirdreality/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/aqara/aqara_utils.lua 78%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/aqara/init.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/aqara/high-precision-motion/init.lua 69%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/ikea/init.lua 97%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 2651f5c

@greens greens merged commit 2b1eba9 into production Feb 20, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants