Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick eve sub driver and various minor changes #1243

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

ctowns
Copy link
Contributor

@ctowns ctowns commented Feb 26, 2024

No description provided.

ctowns and others added 5 commits February 26, 2024 11:25
There is a race condition where sometimes the initial subscription
report will be handled before child devices are done being created.
In this case, the child devices will not recieve the initial value
of the attribute, and will appear as just "connected" or "waiting
for device to update" until they are  manually refreshed or the
state is physically toggled on the device.
* add WL4210 fingerprints

* add probe handling

* remove wl4210s

* standard

* remove unecessary import

* corrections

* zone_status handling

* corrections

* correction date

* use is_alarm1_set, add test for dry event

* fix preferences
* Eve Energy Outlet

- Add Eve Energy Outlet fingerprint

* Eve Energy Outlet

- Add Eve Energy Outlet fingerprint
- Only create the polls (create_poll_schedule and create_poll_report_schedule) if the device supports capabilities.powerConsumptionReport
- When the device is initialized, create child devices with the profile plug-binary for each additional outlet
- Update component_to_endpoint, endpoint_to_component and find_child to support multiple children
- Add a check in on_off_attr_handler to make sure the polling functions are only called for the parent device/endpoint 1, which supports powerConsumption

* Eve Energy Outlet

- Each time an oulet is turned on or off, store the value in a dictionary
- If one of the outlet is on, we should create the poll to monitor the power consumption
- If all the outlet are off, we should delete the poll

* Remove unused log to fix luacheck

* Don't change the profile, this breaks the unit tests

* Eve Energy Outlet

Only run the device_init function for the parent device.
* Cync-Matter-Bulbs-1.01.060

* Adding quotes around id:

* Adding fingerprintfor Cync Outdoor Plug

This fingerprint has passed WWST testing, along with other devices in this PR and is ready to merge. I commited this device in to prevent an additional PR.
@ctowns ctowns requested review from greens and lelandblue February 26, 2024 17:31
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Feb 26, 2024

Channel deleted.

Copy link

github-actions bot commented Feb 26, 2024

Test Results

   55 files    352 suites   0s ⏱️
1 646 tests 1 646 ✅ 0 💤 0 ❌
2 891 runs  2 891 ✅ 0 💤 0 ❌

Results for commit ee63801.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 26, 2024

matter-switch_coverage.xml

File Coverage
All files 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 94%

zigbee-thermostat_coverage.xml

File Coverage
All files 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/vimar/init.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro-ki-zigbee-thermostat/init.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/zenwithin/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/popp/init.lua 74%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sinope/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/leviton/init.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lux-konoz/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against ee63801

Adding New Profile to handle Light Range.
@ctowns ctowns merged commit 1aceed0 into beta Feb 26, 2024
13 checks passed
@ctowns ctowns deleted the cherry-pick/eve-and-fingerprints branch February 26, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants