CHAD-12653 Zigbee ColorTemperature: add dynamic range handling #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
Test Results 56 files 360 suites 0s ⏱️ Results for commit 887a07a. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 887a07a |
tpmanley
reviewed
Feb 28, 2024
| function () | ||
| test.socket.zigbee:__queue_receive({ | ||
| mock_device.id, | ||
| ColorControl.attributes.ColorTempPhysicalMinMireds:build_test_attr_report(mock_device, 555) -- ~1800 K |
There was a problem hiding this comment.
I believe these are flipped, so a good test value for ColorTempPhysicalMinMireds is 154 which is roughly 6500K and a good value for ColorTempPhysicalMaxMireds is 555 which is roughly 1800K
There was a problem hiding this comment.
i.e. the min mireds corresponds to the max kelvin and vice versa
you are absolutely right. what cursed units
ctowns
reviewed
Feb 28, 2024
| if min ~= nil and max ~= nil and min < max then | ||
| device:emit_event_for_endpoint(endpoint_id, capabilities.colorTemperature.colorTemperatureRange({ value = {minimum = min, maximum = max}})) | ||
| device:set_field(BOUND_RECEIVED..MAX, nil) | ||
| device:set_field(BOUND_RECEIVED..MAX) |
There was a problem hiding this comment.
Suggested change
| device:set_field(BOUND_RECEIVED..MAX) | |
| device:set_field(BOUND_RECEIVED..MIN, nil) |
tpmanley
reviewed
Feb 28, 2024
ctowns
reviewed
Feb 29, 2024
greens
force-pushed
the
feature/CHAD-12653
branch
from
50f127e to
affde8b
Compare
tpmanley
approved these changes
Feb 29, 2024
wkhenon
reviewed
Mar 4, 2024
wkhenon
approved these changes
Mar 4, 2024
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Uses the PhysicalMax and PhysicalMin mired values from the color control cluster to dynamically set the min/max range for zigbee bulbs in the base driver.
greens
force-pushed
the
feature/CHAD-12653
branch
from
c562ba0 to
887a07a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the PhysicalMax and PhysicalMin mired values from the color control cluster to dynamically set the min/max range for zigbee bulbs in the base driver.