Aqara Wireless Remote Switch E1 (Single Rocker) #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 56 files 360 suites 0s ⏱️ Results for commit 7134dc0. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a60c69c |
greens
reviewed
Mar 14, 2024
| test.mock_device.add_test_device(mock_device_t1) | ||
| end | ||
|
|
||
| test.set_test_init_function(test_init) | ||
|
|
||
| test.register_coroutine_test( | ||
| "Handle added lifecycle", |
There was a problem hiding this comment.
Suggested change
| "Handle added lifecycle", | |
| "Handle added lifecycle -- e1", |
greens
reviewed
Mar 14, 2024
Comment on lines
100
to
101
|
|
||
|
|
greens
reviewed
Mar 14, 2024
| } | ||
|
|
||
|
|
greens
reviewed
Mar 14, 2024
Comment on lines
24
to
25
| local PRIVATE_ATTRIBUTE_ID = 0x0009 | ||
| local PRIVATE_SWITCH_MODE_ATTRIBUTE_ID = 0x0125 |
There was a problem hiding this comment.
Suggested change
| local PRIVATE_ATTRIBUTE_ID = 0x0009 | |
| local PRIVATE_SWITCH_MODE_ATTRIBUTE_ID = 0x0125 | |
| local PRIVATE_ATTRIBUTE_ID_T1 = 0x0009 | |
| local PRIVATE_ATTRIBUTE_ID_E1 = 0x0125 |
There was a problem hiding this comment.
Thank you, I have modified!
greens
reviewed
Mar 15, 2024
| @@ -1,3 +1,4 @@ | |||
| ---@diagnostic disable: param-type-mismatch, missing-parameter | |||
greens
reviewed
Mar 15, 2024
Comment on lines
+85
to
+91
| if device:get_model() == "lumi.remote.b1acn02" then | ||
| device:send(cluster_base.write_manufacturer_specific_attribute(device, | ||
| PRIVATE_CLUSTER_ID, PRIVATE_ATTRIBUTE_ID_T1, MFG_CODE, data_types.Uint8, 1)) | ||
| elseif device:get_model() == "lumi.remote.acn003" then | ||
| device:send(cluster_base.write_manufacturer_specific_attribute(device, | ||
| PRIVATE_CLUSTER_ID, PRIVATE_ATTRIBUTE_ID_E1, MFG_CODE, data_types.Uint8, 2)) | ||
| end |
There was a problem hiding this comment.
a comment indicating what these both do would be helpful
There was a problem hiding this comment.
ok,when the wireless switch T1 accesses the network, the gateway sends private attribute 0009 to make the device no longer distinguish between the standard gateway and the aqara gateway. When wireless switch E1 is connected to the network, the gateway delivers private attribute 0125 to enable the device to send double-click and long-press packets. Wireless switch T1 supports double and long press by default, while wireless switch E1 does not distinguish between standard gateway and aqara gateway by default. This is the point where they issue different instructions when they enter the network.
wkhenon
approved these changes
Mar 18, 2024
greens
approved these changes
Mar 18, 2024
|
Invitation URL: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.