-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling up beta to production #1254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition where sometimes the initial subscription report will be handled before child devices are done being created. In this case, the child devices will not recieve the initial value of the attribute, and will appear as just "connected" or "waiting for device to update" until they are manually refreshed or the state is physically toggled on the device.
* add WL4210 fingerprints * add probe handling * remove wl4210s * standard * remove unecessary import * corrections * zone_status handling * corrections * correction date * use is_alarm1_set, add test for dry event * fix preferences
Signed-off-by: WangShao <[email protected]>
* Eve Energy Outlet - Add Eve Energy Outlet fingerprint * Eve Energy Outlet - Add Eve Energy Outlet fingerprint - Only create the polls (create_poll_schedule and create_poll_report_schedule) if the device supports capabilities.powerConsumptionReport - When the device is initialized, create child devices with the profile plug-binary for each additional outlet - Update component_to_endpoint, endpoint_to_component and find_child to support multiple children - Add a check in on_off_attr_handler to make sure the polling functions are only called for the parent device/endpoint 1, which supports powerConsumption * Eve Energy Outlet - Each time an oulet is turned on or off, store the value in a dictionary - If one of the outlet is on, we should create the poll to monitor the power consumption - If all the outlet are off, we should delete the poll * Remove unused log to fix luacheck * Don't change the profile, this breaks the unit tests * Eve Energy Outlet Only run the device_init function for the parent device.
* Cync-Matter-Bulbs-1.01.060 * Adding quotes around id: * Adding fingerprintfor Cync Outdoor Plug This fingerprint has passed WWST testing, along with other devices in this PR and is ready to merge. I commited this device in to prevent an additional PR.
…ld-on-add Matter Switch: refresh child devices on added event
Most of these are just refining/augmenting gradual typing to quiet the IDE warnings, but there were a few places that we were missing nil checks or otherwise had other potential bugs that got addressed here.
This removes the API version guard on the auto add/delete scan during event stream connection and instead skips to the next element in the iterator if it detects that the current iteration target is a device record that represents a bridge. We do this because we *do* want the auto-add/auto-delete routine to run on older firmware, as the delete function does feature detection on the lua libs and uses `device:offline()` as a fallback. Plus, auto add will work on all firmware versions, so this is the better UX all around.
…g-hue-bridges-in-startup-auto-delete-checks
The first thing we do is we store the API keys in the datastore right away instead of waiting for a device record to exist. This hardens us against the situation where the driver restarts for any reason while the Hue Bridge device's `added` handler is still executing and is early enough in its execution that we haven't stored the key on the device object yet. We also address an issue where an invalid mDNS response (for example, an ipv6 response) would `return` from the entire mDNS scan function instead of moving on to the rest of the responses returned. In practice, this is not likely to happen, as we don't typically get both an ipv4 and and ipv6 from a Hue bridge, but I noticed it while doing this refactor and felt it was worth addressing. We also address a regression from the automatic add/delete changes, which can lead to the creation of duplicate device records for bulbs in some specific circumstances.
…able-comment Matter Switch: add comment for COMPONENT_TO_ENDPOINT_MAP
Adding New Profile to handle Light Range.
* Feature to Add Fingerprint for Tuo Temp Sensor * Moving tuo fingerprints together * Removed duplicate fingerprint. I removed the fingerprint for the "TUO/ContactDoorAndWindow" device as this fingerprint has already been released to production.
[CHAD-12631] fix(zigbee-button): Adding exception case of manufacturer information for IKEA button
Rolling up main to beta
Channel deleted. |
Test Results 55 files 352 suites 0s ⏱️ Results for commit faf3824. |
matter-sensor_coverage.xml
matter-switch_coverage.xml
zigbee-button_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against faf3824 |
dljsjr
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.