[Closed - Swapped Branches] Smartsense negative handling #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rolling up main to beta
Rolling up main to beta
Rolling up main to beta
Rolling up main to beta
Rolling up main to beta
Rolling up main to beta
…deploy Fixes a recent issue that has arisen with deployment in CN
Rolling up main to beta
Rolling up main to beta
The "device" parameter was missing in the match_profile() call on infoChanged. This would cause the infoChanged event to error and not check for a new profile match. Added unit test to explicitly test this case.
…-covering-missing-parameter Matter Window Covering: add missing parameter
Rolling up main to beta
Rolling up main to beta
rolling up main to beta
Rolling up main to beta
Rolling up main to beta
rolling up main to beta
Rolling up main to beta
* Aqara Smart Plug T1 * modification time --------- Co-authored-by: lelandblue <[email protected]>
…1_plug Aqara Smart Plug T1 (#1127)
An issue with the fingerprint grading system is causing any bridged device with a matching vendorId to match to this fingerprint. We will remove this fingerprint while the issue is being resolved to prevent new bridged devices from joining with the wrong fingerprint.
…-fingerprint Matter Switch: remove Aqara bridged fingerprint
Rolling up main to beta
Rolling up main to beta
rolling up main to beta
This change puts an API Version guard around the call that performs the auto-add/auto-delete scan at startup, which is causing a crash on 0.47 TV's due to an issue with looking up non-existent UUID's. We believe the root of the issue is that the non-existent UUID lookup is related to trying to look up the Hub UUID as the parent of the bridge, but because this is a pretty gnarly issue we're going to roll back while we're confirming our suspicion.
There is a race condition where sometimes the initial subscription report will be handled before child devices are done being created. In this case, the child devices will not recieve the initial value of the attribute, and will appear as just "connected" or "waiting for device to update" until they are manually refreshed or the state is physically toggled on the device.
Rolling up main to beta
Adding New Profile to handle Light Range.
There is a race condition where sometimes the initial subscription report will be handled before child devices are done being created. In this case, the child devices will not recieve the initial value of the attribute, and will appear as just "connected" or "waiting for device to update" until they are manually refreshed or the state is physically toggled on the device.
* add WL4210 fingerprints * add probe handling * remove wl4210s * standard * remove unecessary import * corrections * zone_status handling * corrections * correction date * use is_alarm1_set, add test for dry event * fix preferences
Signed-off-by: WangShao <[email protected]>
* Eve Energy Outlet - Add Eve Energy Outlet fingerprint * Eve Energy Outlet - Add Eve Energy Outlet fingerprint - Only create the polls (create_poll_schedule and create_poll_report_schedule) if the device supports capabilities.powerConsumptionReport - When the device is initialized, create child devices with the profile plug-binary for each additional outlet - Update component_to_endpoint, endpoint_to_component and find_child to support multiple children - Add a check in on_off_attr_handler to make sure the polling functions are only called for the parent device/endpoint 1, which supports powerConsumption * Eve Energy Outlet - Each time an oulet is turned on or off, store the value in a dictionary - If one of the outlet is on, we should create the poll to monitor the power consumption - If all the outlet are off, we should delete the poll * Remove unused log to fix luacheck * Don't change the profile, this breaks the unit tests * Eve Energy Outlet Only run the device_init function for the parent device.
* Cync-Matter-Bulbs-1.01.060 * Adding quotes around id: * Adding fingerprintfor Cync Outdoor Plug This fingerprint has passed WWST testing, along with other devices in this PR and is ready to merge. I commited this device in to prevent an additional PR.
Adding New Profile to handle Light Range.
…d-fingerprints Cherry pick eve sub driver and various minor changes
* Feature to Add Fingerprint for Tuo Temp Sensor * Moving tuo fingerprints together * Removed duplicate fingerprint. I removed the fingerprint for the "TUO/ContactDoorAndWindow" device as this fingerprint has already been released to production.
[CHAD-12631] fix(zigbee-button): Adding exception case of manufacturer information for IKEA button
* Aqara Wireless Mini Switch T1 * modification time * Resolve blank line * Add CopyRight Profile.
* Aqara Smart Smoke Detector * Fix formatting issues * Example Delete the configurations that support self-check * Update the self-check code of the device * Update the self-check code of the device * Remove duplicate Aqara * Delete debug information * Update self-check * Update PR * Add metadata * Adding the correct CN translation for Aqara Product * Delete .yml
This includes support for a standalone pressure sensor and also a temp, humidity and pressure sensor, both w/ or w/o battery.
The majority of these fixes are concurrency races: Due to Hue's heavy usage of additional Cosock coroutines, it can be the case that functions that have been passed references to device records will be operating on a device record for a deleted device. This can cause unexpected nil index errors and crashes. We attempt to minimize that here with heuristics; in particular, a device that has been deleted will return `nil` for *any* of its table keys. So we check a field that we *know* a device record should have, its `.id` field. We wrap all handlers in a closure that does a sanity check on the status of the device record using this heuristic, and we wrap the handler itself in a pcall. We also address some one-off locations where nil field indexes can occur for other reasons, and introduce some additional defensiveness around other places where we've observed nil index crashes in crash metrics.
…-use-device-after-delete
…re-sensor matter-sensor: Add support for Pressure Sensor
…ismart MT25B, MT82, MT25A, ZM25M (#1121) * new device/ Zemismart MT25B and MT82 * Adding two new fingerprints for the MT25A and ZM25M Devices * Change the MT25B profile to be window-covering Change the MT25B profile to be window-covering, since we do not have confirmation from the partner that this supports battery. If it does, then the driver should still accommodate for this
* Aqara LED Light Bulb T1 (Tunable White) * modification time * Fixed the intermediate level reported during device dimming
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Closed for swapped branches |
|
Invitation URL: |
wkhenon
changed the title
|
matter-sensor_coverage.xml
matter-switch_coverage.xml
matter-window-covering_coverage.xml
zigbee-button_coverage.xml
zigbee-smoke-detector_coverage.xml
zigbee-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7221665 |
wkhenon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1227
This PR incorporates the changes made in the original PR and also adds unit tests for these changes