fix aqara smoke detector reonboarding issue #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 95035c6 |
greens
approved these changes
Apr 1, 2024
wkhenon
approved these changes
Apr 2, 2024
reference: wash-2068 STSE-2611 Signed-off-by: Ma Xinjian <[email protected]>
MaXinjian
force-pushed
the
smoke-reonboard
branch
from
8d3b532 to
95035c6
Compare
|
Since #1293 have been merged to improve code coverage of aqara gas sensor, please trigger code coverage github action again. I think code coverage already beyond 90% |
greens
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue that smoke detection doesn't work after reonboarding
This is a fix for re-onboarding scenario:
WASH-2068
STSE-2611