Cherry-pick fixes for matter switch limit reads #1307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses minor issues discovered after PR 1220 was merged into main.
It was decided that if values read from the device are outside of the supported capability range, that the capability should not be sent rather than sending the capability with default values.
Resolving error resulting from luacheck.
Add comment for level range conversion that was removed by accident.
Adds a "sane" color temp range that will be used to determine if range data received from a device is "sane" or not. If not, the values are discarded. Adds a default color range of 2200K-6500K for color temp profiles.
|
Duplicate profile check: Warning - duplicate profiles detected. |
Test Results 56 files 362 suites 0s ⏱️ Results for commit e9ad9b3. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e9ad9b3 |
nickolas-deboom
approved these changes
Apr 8, 2024
|
Closing this in favor or merging main to beta here #1311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking the commits from #1304 into beta