Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Device (Matter Sensor) Aqara Motion and Light Sensor P2 #1331

Merged
merged 4 commits into from
Jun 18, 2024
Merged

New Device (Matter Sensor) Aqara Motion and Light Sensor P2 #1331

merged 4 commits into from
Jun 18, 2024

Conversation

lelandblue
Copy link
Contributor

This is an addition of the Matter Aqara Motion and Light Sensor P2 device that is seeking WWST Certification.

@lelandblue lelandblue requested review from ctowns and z-michel April 17, 2024 13:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

Test Results

   57 files    367 suites   0s ⏱️
1 780 tests 1 780 ✅ 0 💤 0 ❌
3 095 runs  3 095 ✅ 0 💤 0 ❌

Results for commit 7604281.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

File Coverage
All files 84% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/init.lua 71% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/types/Feature.lua 66% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/server/attributes/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/server/attributes/MeasuredValue.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/server/commands/init.lua 57% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7604281

@lelandblue lelandblue closed this May 23, 2024
@lelandblue
Copy link
Contributor Author

Closing PR, a new PR will be created after the partner re-submits for certification with a profile that supports battery

@lelandblue lelandblue reopened this May 24, 2024
lelandblue added 2 commits May 24, 2024 10:43
@lelandblue
Updating the device profile to new profile to include battery
935f8e3 
The original WWST Certification request for this device selected an incorrect profile that did not support battery. 

The partner has since resubmitted, and I have updated the PR to point to the motion-illuminance-battery as a result
@lelandblue
Merge branch 'main' into new-device-Matter-Aqara-Light-Motion-P2
7604281
@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

Channel deleted.

@lelandblue lelandblue requested a review from ctowns May 31, 2024 13:22
@lelandblue lelandblue merged commit d8fb2e1 into main Jun 18, 2024
11 checks passed
@lelandblue lelandblue deleted the new-device-Matter-Aqara-Light-Motion-P2 branch June 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianooshkarami kianooshkarami kianooshkarami left review comments

@ctowns ctowns ctowns approved these changes

@z-michel z-michel Awaiting requested review from z-michel

@nickolas-deboom nickolas-deboom Awaiting requested review from nickolas-deboom

Assignees
No one assigned
Labels
do not merge WWST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lelandblue @kianooshkarami @ctowns